What kind of flash should I use

See the mailing list thread on this topic - http://thread.gmane.org/gmane.comp.security.firewalls.pfsense.user/3189

Generally speaking, SLC is the most suited for a firewall type deployment. It has a longer life and is more robust. The only down side is cost.